From f438fb87d8765633e8550e1108a7956e9f5d70c2 Mon Sep 17 00:00:00 2001 From: Peter Johanson Date: Mon, 13 Dec 2021 17:10:47 -0500 Subject: [PATCH] chore: Add a few more items to PR template. * Kconfig.defconfig conditional correctness. * Keyboard availability. --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7443c24d..9c3543dd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,4 +8,6 @@ - [ ] Keymaps do not use deprecated key defines (Check using the [upgrader tool](https://zmk.dev/docs/codes/keymap-upgrader)) - [ ] `&pro_micro` used in favor of `&pro_micro_d/a` if applicable - [ ] If split, no name added for the right/peripheral half + - [ ] Kconfig.defconfig file correctly wraps *all* configuration in conditional on the shield symbol - [ ] `.conf` file has optional extra features commented out + - [ ] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)