From b4c0967645ab7b3952a3946663e16f02abf8a927 Mon Sep 17 00:00:00 2001 From: Okke Formsma Date: Wed, 9 Dec 2020 20:36:03 +0100 Subject: [PATCH] fix(west) test command should not swallow errors. --- app/scripts/west_commands/test.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/scripts/west_commands/test.py b/app/scripts/west_commands/test.py index b8f87c7d..f79547b9 100644 --- a/app/scripts/west_commands/test.py +++ b/app/scripts/west_commands/test.py @@ -4,6 +4,7 @@ '''Test runner for ZMK.''' import os +import subprocess from textwrap import dedent # just for nicer code indentation from west.commands import WestCommand @@ -30,4 +31,6 @@ class Test(WestCommand): def do_run(self, args, unknown_args): # the run-test script assumes the app directory is the current dir. os.chdir(f'{self.topdir}/app') - exit(os.system(f'{self.topdir}/app/run-test.sh {args.test_path}')) + completed_process = subprocess.run( + [f'{self.topdir}/app/run-test.sh', args.test_path]) + exit(completed_process.returncode)